Contents
description bug_report

Generic types in PopScope

Contents

Summary

#

Added a generic type in PopScope class and replaced the onPopInvoked with a new method onPopInvokedWithResult. The new method takes a boolean didPop and a result as position parameters.

Also replaced the Form.onPopInvoked with Form.onPopInvokedWithResult for the same reason.

Context

#

Previously, PopScope didn't have a way to access the pop result when onPopInvoked was called. The generic type is added to the PopScope class so that the new method onPopInvokedWithResult can access the type-safe result.

Description of change

#

Added a generic type in PopScope class and a new method onPopInvokedWithResult. The onPopInvoked was deprecated in the favor of onPopInvokedWithResult.

Also added a new method onPopInvokedWithResult to Form to replace onPopInvoked.

Migration guide

#

Code before migration

dart
import 'package:flutter/material.dart';

void main() {
  runApp(
    MaterialApp(
      navigatorKey: nav,
      home: Column(
        children: [
          Form(
            canPop: false,
            onPopInvoked: (bool didPop) {
              if (didPop) {
                return;
              }
              launchConfirmationDialog();
            },
            child: MyWidget(),
          ),
          PopScope(
            canPop: false,
            onPopInvoked: (bool didPop) {
              if (didPop) {
                return;
              }
              launchConfirmationDialog();
            },
            child: MyWidget(),
          ),
        ],
      ),
    ),
  );
}

Code after migration

dart
import 'package:flutter/material.dart';

void main() {
  runApp(
    MaterialApp(
      navigatorKey: nav,
      home: Column(
        children: [
          Form(
            canPop: false,
            onPopInvokedWithResult: (bool didPop, Object? result) {
              if (didPop) {
                return;
              }
              launchConfirmationDialog();
            },
            child: MyWidget(),
          ),
          PopScope<Object?>(
            canPop: false,
            onPopInvokedWithResult: (bool didPop, Object? result) {
              if (didPop) {
                return;
              }
              launchConfirmationDialog();
            },
            child: MyWidget(),
          ),
        ],
      ),
    ),
  );
}

The generic type should match the generic type of the Route that the PopScope is in. If the route uses int as its generic type, consider using PopScope<int>.

If the PopScope widgets are shared across multiple routes with different types, you can use PopScope<Object?> to catch all possible types.

Timeline

#

Landed in version: 3.22.0-12.0.pre-56 In stable release: TBD

References

#

API documentation:

Relevant issue:

Relevant PR: